Conversation
Consolidates repeated batching preamble into a single paragraph, updates deprecated TodoWrite tool references to TaskCreate/TaskUpdate, and adds missing "in parallel" to commit step 3 to match upstream wording. Assisted-by: Claude:claude-sonnet-4-6[1m]
📝 WalkthroughWalkthroughVersion 1.3.0 of the Git plugin is released with a new safety constraint preventing direct commits to mainline, updated instruction text for parallel bash execution guidance, and modified tool prohibitions replacing TodoWrite with TaskCreate and TaskUpdate in both commit and pull request workflows. ChangesGit Plugin v1.3.0 Release
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
git/scripts/git-instructions.sh (1)
195-199:⚠️ Potential issue | 🟡 Minor | ⚡ Quick win"in parallel" on commit step 3 contradicts the sequential dependencies of all three sub-steps.
The three sub-steps are strictly ordered:
git add→commit→git status. None of these can be parallelised. The existing note on line 199 acknowledges the commit→status dependency but doesn't cover the stage→commit dependency either. Adding "in parallel" to the header makes the instructions self-contradictory.🐛 Proposed fix
-3. Run the following commands in parallel: +3. Run the following commands sequentially:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@git/scripts/git-instructions.sh` around lines 195 - 199, The header "Run the following commands in parallel" is incorrect; update it to indicate sequential execution and clarify dependencies: change the header to something like "Run the following commands sequentially" (or remove "in parallel"), and adjust the note to state the strict ordering: first run `git add` to stage files, then `git commit` with the Assisted-by trailer `Assisted-by: Claude:<your-model-id>`, and only after the commit completes run `git status` to verify; ensure the text references the three steps (`git add`, `git commit`, `git status`) so the stage→commit and commit→status dependencies are explicit.git/CLAUDE.md (1)
75-75:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winLine 75 is now stale — tool references were replaced, not removed.
After this PR,
git-instructions.shstill includes tool restriction lines (NEVER use the TaskCreate, TaskUpdate, or Agent tools/DO NOT use the TaskCreate, TaskUpdate, or Agent tools). Line 75 documenting these references as "removed" is no longer accurate.📝 Suggested update
-- `TodoWrite or Agent tools` references removed (not relevant to plugin context) +- `TodoWrite` replaced with `TaskCreate`/`TaskUpdate`; Agent tool restriction retained🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@git/CLAUDE.md` at line 75, Update the stale sentence that says "`TodoWrite or Agent tools` references removed" to accurately reflect that those tool references were replaced rather than removed; edit CLAUDE.md (the sentence at or around line 75) to say the references were replaced/updated and add a note that git-instructions.sh still contains the restriction lines "NEVER use the TaskCreate, TaskUpdate, or Agent tools" and "DO NOT use the TaskCreate, TaskUpdate, or Agent tools" so the documentation and git-instructions.sh remain consistent.
🧹 Nitpick comments (1)
git/scripts/git-instructions.sh (1)
204-204: ⚡ Quick winCoding guideline requires removing task-tool restrictions, not replacing them.
The guideline for
git/**/git-instructions.shstates: "RemoveTodoWrite or Agent toolsreferences from git instructions as they are not relevant to plugin context." Both lines replace the deprecatedTodoWritereference withTaskCreate, TaskUpdate, or Agentrather than removing the restriction entirely, which violates the guideline.If the intent is to keep the restriction with updated names, the guideline itself should be revised first. Otherwise, remove both lines:
✂️ Proposed removal (per guideline)
Important notes: - NEVER run additional commands to read or explore code, besides git bash commands -- NEVER use the TaskCreate, TaskUpdate, or Agent tools - DO NOT push to the remote repository unless the user explicitly asks you to do soImportant: -- DO NOT use the TaskCreate, TaskUpdate, or Agent tools - Return the PR URL when you're done, so the user can see itAs per coding guidelines: "Remove
TodoWrite or Agent toolsreferences from git instructions as they are not relevant to plugin context."Also applies to: 246-246
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@git/scripts/git-instructions.sh` at line 204, Remove the restriction line that reads "NEVER use the TaskCreate, TaskUpdate, or Agent tools" from git-instructions.sh (and the identical occurrence noted at the other location) so that no references to TodoWrite/TaskCreate/TaskUpdate/Agent remain in the git instructions; simply delete those lines entirely to comply with the guideline that task-tool references be removed rather than replaced.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@git/CLAUDE.md`:
- Line 75: Update the stale sentence that says "`TodoWrite or Agent tools`
references removed" to accurately reflect that those tool references were
replaced rather than removed; edit CLAUDE.md (the sentence at or around line 75)
to say the references were replaced/updated and add a note that
git-instructions.sh still contains the restriction lines "NEVER use the
TaskCreate, TaskUpdate, or Agent tools" and "DO NOT use the TaskCreate,
TaskUpdate, or Agent tools" so the documentation and git-instructions.sh remain
consistent.
In `@git/scripts/git-instructions.sh`:
- Around line 195-199: The header "Run the following commands in parallel" is
incorrect; update it to indicate sequential execution and clarify dependencies:
change the header to something like "Run the following commands sequentially"
(or remove "in parallel"), and adjust the note to state the strict ordering:
first run `git add` to stage files, then `git commit` with the Assisted-by
trailer `Assisted-by: Claude:<your-model-id>`, and only after the commit
completes run `git status` to verify; ensure the text references the three steps
(`git add`, `git commit`, `git status`) so the stage→commit and commit→status
dependencies are explicit.
---
Nitpick comments:
In `@git/scripts/git-instructions.sh`:
- Line 204: Remove the restriction line that reads "NEVER use the TaskCreate,
TaskUpdate, or Agent tools" from git-instructions.sh (and the identical
occurrence noted at the other location) so that no references to
TodoWrite/TaskCreate/TaskUpdate/Agent remain in the git instructions; simply
delete those lines entirely to comply with the guideline that task-tool
references be removed rather than replaced.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 307c8946-32fd-47ed-97e9-25b75c623209
📒 Files selected for processing (3)
git/.claude-plugin/plugin.jsongit/CLAUDE.mdgit/scripts/git-instructions.sh
1 participant
Summary
TodoWritetool references toTaskCreate, TaskUpdate, or Agentin both the commit and PR sectionsgit/CLAUDE.md's differences list; bumps plugin version to 1.3.0An Opus subagent did a full line-by-line comparison against the upstream
Piebald-AI/claude-code-system-promptsfiles and confirmed all differences fall into the documented expected categories — no unexpected drift found.Test plan
bash git/scripts/git-instructions.shand verify the preamble paragraph appears once before "Git Safety Protocol:", steps 1 and 3 in both sections start withRun the following..., and tool names readTaskCreate, TaskUpdate, or Agentclaude plugin validate ./git— expect✔ Validation passednpx markdownlint-cli2 --config .markdownlint-cli2.jsonc "git/**/*.md"— expect 0 errorsgit/.claude-plugin/plugin.jsonversion is1.3.0Summary by CodeRabbit
Chores
Documentation